Add feature flag to drop dependencies from test execution #571
Conversation
The current model requires that packages have already finished building prior to invoking tests, meaning that there aren't any ordering constraints on test execution.
|
Prototype builds:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 87.26% 87.26%
=======================================
Files 67 67
Lines 3902 3904 +2
Branches 773 773
=======================================
+ Hits 3405 3407 +2
Misses 391 391
Partials 106 106 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@cottsay and I had a good conversation about this change and the reasons we can't yet merge it. I'd really like to see the info in that discussion added to the PR body but I totally agree with the approach.
|
I understand that this can't be merged in the nearer term, but would you accept an earlier merge of this functionality behind an |
Ok, it looks like you have added a feature flag for this. I think I use this feature by setting the following environment variable: Is that right? |
That's correct. As soon as I get readthedocs deployments running again, I'll add information on the semantics of feature flags. |
cottsay
changed the title
The current model requires that packages have already finished building prior to invoking tests, meaning that there aren't any ordering constraints on test execution.
Before we can merge this PR, we have some work to do in the ROS 2 codebase, where there is global state among tests and possible collisions during execution. Once we've developed a cohesive plan for dealing with those collisions, we can consider increasing the parallelism here.