Allow additional Popen arguments through task.run #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to b6c977a, which made the same change to subprocess.run, which this function calls.
nuclearsandwich
approved these changes
Sep 8, 2023
|
Hello @cottsay, I'm having some issues with the micro-ROS CI. At first glance, I guess that it may be related to this PR: https://github.com/micro-ROS/micro_ros_setup/actions/runs/6141791063/job/16662914677 Could you confirm that this inner |
|
@pablogs9 - The first occurrence of that pattern was over 24 hrs before this change was even merged. Also, I believe |
|
Thanks, @cottsay, I will investigate further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #411, which made the same change to subprocess.run, which this function calls.