Remove setup.py link after successful _undo_develop #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function reverts a previous setuptools 'develop' operation, but doesn't actually clean up the artifacts under the build tree that it used to determine that 'develop' was previously used. The result is that after performing a build with --symlink-install, all subsequent builds of that package without --symlink-install will run the commands to "undo" the develop operation even if there is nothing to undo. This should provide a small performance improvement under those specific circumstances.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 81.93% 81.89% -0.05%
==========================================
Files 65 65
Lines 3753 3755 +2
Branches 724 725 +1
==========================================
Hits 3075 3075
- Misses 622 624 +2
Partials 56 56
☔ View full report in Codecov by Sentry. |
nuclearsandwich
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function reverts a previous setuptools 'develop' operation, but doesn't actually clean up the artifacts under the build tree that it used to determine that 'develop' was previously used. The result is that after performing a build with --symlink-install, all subsequent builds of that package without --symlink-install will run the commands to "undo" the develop operation even if there is nothing to undo.
This should provide a small performance improvement under those specific circumstances.