Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address flake8 E721 violations #580

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Address flake8 E721 violations #580

merged 1 commit into from
Sep 12, 2023

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Sep 5, 2023

These violations don't show up in our CI right now because we've pinned flake8<6, but when that pin is dropped, we'll have enforcement for this rule.

These violations don't show up in our CI right now because we've pinned
flake8<6, but when that pin is dropped, we'll have enforcement for this
rule.
@cottsay cottsay self-assigned this Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c8995e3) 81.93% compared to head (34c2a1b) 81.93%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files          65       65           
  Lines        3753     3753           
  Branches      724      724           
=======================================
  Hits         3075     3075           
  Misses        622      622           
  Partials       56       56           
Files Changed Coverage Δ
colcon_core/verb/__init__.py 100.00% <ø> (ø)
colcon_core/package_augmentation/__init__.py 100.00% <100.00%> (ø)
colcon_core/package_descriptor.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay merged commit 42c1e2b into master Sep 12, 2023
35 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/flake8-e721 branch September 12, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants