Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Compatibility with EmPy 4 #627

Closed
wants to merge 4 commits into from
Closed

WIP: Compatibility with EmPy 4 #627

wants to merge 4 commits into from

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 11, 2024

I believe this is the minimum set of changes necessary to use EmPy 4.

This needs to be updated to be compatible with EmPy 3 as well before being merged - there is no way we can cold-cut to v4.

@cottsay cottsay self-assigned this Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.01%. Comparing base (f9072e8) to head (a470f49).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
colcon_core/shell/template/__init__.py 48.38% 10 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   87.34%   87.01%   -0.34%     
==========================================
  Files          67       67              
  Lines        3913     3934      +21     
  Branches      776      782       +6     
==========================================
+ Hits         3418     3423       +5     
- Misses        391      401      +10     
- Partials      104      110       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@clalancette
Copy link
Contributor

FYI; I've rebased this onto the latest, and also merged the Empy 3/4 compatibility work from @ahcorde into this. I don't think this is quite ready to go in, but I think it is closer now.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants