Add Debian 'Replaces: colcon' field #628
Conversation
Upstream Debian has decided to package colcon, and they created a package simply called 'colcon' which provides only the /usr/bin/colcon executable and some weak dependencies as a sort of replacement for colcon-common-extensions. This conflicts with our python3-colcon-core package during unpacking. We could add 'Conflicts: colcon', but I think this is a great use case for 'Replaces:' because the only file provided by 'colcon' is /usr/bin/colcon, which we obviously provide here. This way, folks can still successfully install 'colcon' and get the weak dependencies even if our version of python-colcon-core is installed, and our copy of /usr/bin/colcon will take precedence over the one provided by 'colcon'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #628 +/- ##
=======================================
Coverage 83.54% 83.54%
=======================================
Files 66 66
Lines 3816 3816
Branches 745 745
=======================================
Hits 3188 3188
Misses 554 554
Partials 74 74 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
For reference the upstream package: https://packages.debian.org/sid/colcon
I wasn't aware of the overwrite individual files. But this seems like a reasonable approach.
Will this potentially have us end up with the extensions that conflict even if the core executable is upgradeable?
I see that the package actually only has 3 files it installs: https://packages.debian.org/sid/all/colcon/filelist
/usr/bin/colcon
/usr/share/doc/colcon/changelog.Debian.gz
/usr/share/doc/colcon/copyright
So it's not really a big difference, except that others can still depend on it. The other approach would be to do the triplet, replaces, provides, conflicts. But I'm fine with trying this minimal approach.
Upstream Debian has decided to package colcon, and they created a package simply called 'colcon' which provides only the
/usr/bin/colconexecutable and some weak dependencies as a sort of replacement forcolcon-common-extensions. This conflicts with ourpython3-colcon-corepackage during unpacking.We could add
Conflicts: colcon, but I think this is a great use case forReplaces:because the only file provided bycolconis/usr/bin/colcon, which we obviously provide here. This way, folks can still successfully installcolconand get the weak dependencies even if our version ofpython3-colcon-coreis installed, and our copy of/usr/bin/colconwill take precedence over the one provided bycolcon.https://www.debian.org/doc/debian-policy/ch-relationships.html#overwriting-files-and-replacing-packages-replaces