Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support old 'toml' package for Focal #670

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Support old 'toml' package for Focal #670

merged 1 commit into from
Sep 27, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Sep 27, 2024

I'm not thrilled about using the deprecated 'toml' package, but tomli isn't available in Focal as a system package. The changes here will only fall back to 'toml' as a last resort, which should allow us to keep Focal support alive for a while longer.

This should address the deb regression on Focal in colcon-core 0.18.0.

@cottsay cottsay added the bug Something isn't working label Sep 27, 2024
@cottsay cottsay added this to the 0.18.1 milestone Sep 27, 2024
@cottsay cottsay self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.32%. Comparing base (cb9bd9d) to head (de9a48f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
colcon_core/python_project/spec.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   87.36%   87.32%   -0.05%     
==========================================
  Files          68       68              
  Lines        3942     3945       +3     
  Branches      777      777              
==========================================
+ Hits         3444     3445       +1     
- Misses        394      396       +2     
  Partials      104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I'm not thrilled about using the deprecated 'toml' package, but tomli
isn't available in Focal as a system package. The changes here will only
fall back to 'toml' as a last resort, which should allow us to keep
Focal support alive for a while longer.
@cottsay cottsay merged commit 2a371ee into master Sep 27, 2024
36 checks passed
@cottsay cottsay deleted the cottsay/old-toml branch September 27, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants