Port sequential executor tests to parallel executor #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage ? 80.15%
=========================================
Files ? 2
Lines ? 131
Branches ? 40
=========================================
Hits ? 105
Misses ? 16
Partials ? 10 ☔ View full report in Codecov by Sentry. |
nuclearsandwich
approved these changes
Aug 19, 2023
cottsay
force-pushed
the
cottsay/executor-test
branch
from
94eb620
to
3bf4e11
Compare
This is a copy/paste of the sequential executor tests from colcon-core with appropriate modifications to accomodate the parallel executor. Not perfect test coverage, but better than nothing. This change comes at the cost of suppressing ResourceWarnings. There is a problem somewhere in colcon-core's orchestration that sometimes causes a leaked socket. When the problem is fixed in colcon-core, we should be able to drop the suppression here too. Also enable codecov on this repository to track the coverage.
cottsay
force-pushed
the
cottsay/executor-test
branch
from
3bf4e11
to
f8e34b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy/paste of the sequential executor tests from colcon-core with appropriate modifications to accomodate the parallel executor. Not perfect test coverage, but better than nothing.
Also enable codecov on this repository to track the coverage.