Suppress pkg_resources deprecation in flake8_import_order #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearsandwich
approved these changes
Aug 19, 2023
| @@ -52,6 +52,7 @@ filterwarnings = | |||
| error | |||
| # Suppress deprecation warnings in other packages | |||
| ignore:lib2to3 package is deprecated::scspell | |||
| ignore:pkg_resources is deprecated as an API::flake8_import_order | |||
There was a problem hiding this comment.
Spirit of the stairwell review comment: Do we have a tracking issue for the pkg_resources usage in colcon overall which we could add a comment to for this suppression?
There was a problem hiding this comment.
All of these suppressions are for problems in other packages, so there's nothing we can do in colcon to fix them. The only reason they need to be called out like this is that we're setting filterwarnings = error to make noise about problems in colcon itself. Unfortunately, we can't use wildcards in this filter, because filterwarnings = error::colcon.* is what we actually want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.