Drop Windows event loop hack in Python 3.8+ #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 80.91% 81.06% +0.14%
==========================================
Files 2 2
Lines 131 132 +1
Branches 40 41 +1
==========================================
+ Hits 106 107 +1
Misses 16 16
Partials 9 9
☔ View full report in Codecov by Sentry. |
In Python versions prior to 3.8, it appears that attempting to close the event loop after a Ctrl-C would reliably hang the process, which would need to be killed. I've been unable to reproduce the behavior in any newer Python versions, so I think it's time to set the timeline for removing the hack entirely. This should take care of the common ResourceWarning messages when using newer Python versions.
cottsay
force-pushed
the
cottsay/resource-warning
branch
from
6d95a96
to
c8162ad
Compare
cottsay
changed the title
Crola1702
approved these changes
Sep 13, 2023
I'd call it a bugfix for Python >= 3.8 actually. Earlier than that, we still can't reliably call There should be no change in behavior for Python < 3.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python versions prior to 3.8, it appears that attempting to close the event loop after a Ctrl-C would reliably hang the process, which would need to be killed.
I've been unable to reproduce the behavior in any newer Python versions, so I think it's time to set the timeline for removing the hack entirely.
This should take care of the common ResourceWarning messages when using newer Python versions.
This change was already made in colcon/colcon-core#573 and colcon/colcon-core#581.