Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrunge f38 #77

Open
wants to merge 30 commits into
base: fedora38_x86_64
Choose a base branch
from
Open

Mrunge f38 #77

wants to merge 30 commits into from

Conversation

mrunge
Copy link
Member

@mrunge mrunge commented Apr 24, 2023

No description provided.

Marc Fournier and others added 30 commits February 11, 2019 22:06
Particularly, cut the too verbose "ldd" output.
Create docker-image.yml

The intention here is to just enable the workflow and to have any subsequent changes tested by CI.
These will act as a template and allow new actions to be tested when
changes are pushed to dev branches.
This consist of two sets of jobs:
* daily builds that build unstable/rolling distros
* weekly job for stable distros

Both jobs will:

* Build each of the specified containers
* Push the container images to dockerhub
* [gha] Add no-op jobs for each set of actions

These will act as a template and allow new actions to be tested when
changes are pushed to dev branches.

* [githubactions] Add a job for PRs to container branches

Add a job that builds on each PR to a non-main branch (i.e.
distro/flavor branches). The workflow will:

* Build the container
* Run the container
* Try to compile collectd in the container to verify that it works

This workflow does NOT publish the container.
Building rawhide in github actions fails for some strange reason.
…ectd#20)

The job will run when there's a push (i.e. PR merged) to any branch
other than main.
The job will:

* Build the container
* Publish the container image to dockerhub
Use Debian 11 (bullseye) and drop Debian 8 (Jessie) and Debian 9 (stretch), which are both out of support.
Replace ``make test`` with ``make check``
Remove the push and pull_request triggers from periodic jobs
These triggers were there for testing intially.
The on-merge action did not work, when  collectd#55 was merged.
Trigger has been updated, based on the example in [1].

[1] https://github.community/t/trigger-workflow-only-on-pull-request-merge/17359/4
Add ``--errors-for-leak-kinds=definite`` valgrind opt so
``make check`` doesn't fail on possible memory leaks
* [gha][PR] Update the PR tests to split tests

This change splits the build and test stages into separate steps.
The purpose of this is to make it easier to make a step as optional.
This change is being added because some distros don't reliably pass the
unit tests in the gate.

A secondary benifit of this is that the jobs can be easily be extended
later by adding additional steps, instead of adding the commands into a
monolithic super step.
Another benifit of this is better reporting, as it is easier to see what
stage the tests fail on, and allow independant test steps to continue to
run even if previous tests failed.

* Update .github/workflows/pr-jobs.yml

Co-authored-by: Matthias Runge <mrunge@matthias-runge.de>

Co-authored-by: Matthias Runge <mrunge@matthias-runge.de>
This adds Fedora 35 and 36; Fedora 34 is out of support and will be dropped soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants