Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize pas.plugins.oidc #36

Merged
merged 9 commits into from
Nov 10, 2023
Merged

Modernize pas.plugins.oidc #36

merged 9 commits into from
Nov 10, 2023

Conversation

ericof
Copy link
Member

@ericof ericof commented Nov 8, 2023

@ericof ericof requested review from mamico and erral November 9, 2023 19:17
@ericof ericof marked this pull request as ready for review November 9, 2023 19:17
@ericof
Copy link
Member Author

ericof commented Nov 9, 2023

I would suggest to release this as 1.0b1, and tell people to pin to 1.0a6 if they are using it with Plone 5.2

mamico
mamico approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@mamico mamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome!

@ericof ericof merged commit 9b41090 into main Nov 10, 2023
5 checks passed
@ericof ericof deleted the issue-32-plone-meta branch November 10, 2023 14:55
@erral
Copy link
Member

erral commented Nov 10, 2023

I would suggest to release this as 1.0b1, and tell people to pin to 1.0a6 if they are using it with Plone 5.2

I would suggest to release 1.0a6 as 1.0 with Plone 5.2 support and a 2.0 with Plone 6-only.

@ericof
Copy link
Member Author

ericof commented Nov 10, 2023

@erral, I agree with this approach.
@mamico, could you please make a 1.0.0 release?

@mauritsvanrees
Copy link
Member

Just as a quick note: both 1.0.0 and 2.0.0a1 seem to work fine in our test environment for one customer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamico mamico mamico approved these changes

@erral erral Awaiting requested review from erral

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow dict instances to hold userinfo Move tests to pytest Drop support for Plone 5.2 Use plone/meta
4 participants
@ericof @erral @mauritsvanrees @mamico