Allow handlers to use rescue_from in a way familiar to ActionController users #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er users ActiveSupport::Rescuable does close to what we need, but rather than calling render or redirect, handlers return an object (which may be a Twirp::Error). We refine ActiveSupport::Rescuable to return the result of the rescue_from block/method.
albus522
reviewed
Oct 4, 2024
Comment on lines
+10
to
+18
| visited_exceptions << exception | ||
|
|
||
| if (handler = handler_for_rescue(exception, object: object)) | ||
| handler.call exception | ||
| elsif exception | ||
| if visited_exceptions.include?(exception.cause) | ||
| nil | ||
| else | ||
| rescue_with_handler(exception.cause, object: object, visited_exceptions: visited_exceptions) |
There was a problem hiding this comment.
Suggested change
| visited_exceptions << exception | |
| if (handler = handler_for_rescue(exception, object: object)) | |
| handler.call exception | |
| elsif exception | |
| if visited_exceptions.include?(exception.cause) | |
| nil | |
| else | |
| rescue_with_handler(exception.cause, object: object, visited_exceptions: visited_exceptions) | |
| if (handler = handler_for_rescue(exception, object: object)) | |
| handler.call exception | |
| elsif exception | |
| if visited_exceptions.include?(exception.cause) | |
| nil | |
| else | |
| rescue_with_handler(exception.cause, object: object, visited_exceptions: visited_exceptions << exception) |
There was a problem hiding this comment.
That's better, but the original method was copied out of ActiveSupport so I'm tempted to leave it as close as possible for easier comparison in the future.
albus522
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveSupport::Rescuable does close to what we need, but rather than calling render or redirect, handlers return an object (which may be a Twirp::Error). We refine ActiveSupport::Rescuable to return the result of the rescue_from block/method.