Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make bsp build on TestModule success instead of fail #4103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

make bsp build on TestModule success instead of fail #4103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bsp/worker/src/mill/bsp/worker/MillBuildServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ private class MillBuildServer(
case (m: SemanticDbJavaModule, ev) if clientWantsSemanticDb =>
(m.compiledClassesAndSemanticDbFiles, ev)
case (m: JavaModule, ev) => (m.compile, ev)
case (m: TestModule, ev) => (Task.Anon { () }, ev)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case (m: TestModule, ev) => (Task.Anon { () }, ev)
// See also https://youtrack.jetbrains.com/issue/SCL-23352
case (m: TestModule, ev) =>
val task = Task.Anon {
T.log.debug("Ignoring invalid compile request for test module ${m.bspBuildTarget.displayName}")
}
(task, ev)

case (m, ev) => Task.Anon {
Result.Failure(
s"Don't know how to compile non-Java target ${m.bspBuildTarget.displayName}"
Expand Down
Loading