-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part of #3928 [Web Examples] Add First Class Python Support #4107
base: main
Are you sure you want to change the base?
Part of #3928 [Web Examples] Add First Class Python Support #4107
Conversation
@jodersky and @lihaoyi Please Review the code once... Key Points:
|
anyone up there please review... |
I saw your request and will review it |
@jodersky sir i think you are busy so now i am working on Docs and let's review after that finally ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a first glance this looks great, @himanshumahajan138! Could you please use python's style guide in all examples however? In particular method names in python should not be camelCase
, but snake_case
@jodersky Sir, Let's Finalize this ✨ |
hey, I'll go over it again today
…On Thu, Dec 19, 2024, 09:03 Himanshu Mahajan ***@***.***> wrote:
@lihaoyi <https://github.com/lihaoyi> sir i think @jodersky
<https://github.com/jodersky> Sir is Busy but no worry, code is already
satisfied and checked by him in first review and now only docs review is
pending so i think if you are less busy then after reviewing we can merge
this PR
Hope you Understand!
—
Reply to this email directly, view it on GitHub
<#4107 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHV3JBLJKA4LWTXVCPNFNT2GJ4THAVCNFSM6AAAAABTNSPQOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJTGAYTINBUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That's great to hear from your side ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I'm not knowledgeable with Django, but what I see makes sense.
Thanks for waiting so long for the review
object unitTest extends PythonTests with TestModule.Unittest | ||
object integrationTest extends PythonTests with TestModule.Unittest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is super nitpicky, but I personally always find it a bit weird to use mixed case names in folders. If you'd like to follow what's done in some other areas of mill, I would suggest to rename unitTest => test
and integrationTest => itest
But I'm only expressing a very subjective point of view, so feel free to ignore this if you prefer.
Pull Request
Adds First Class Python Support [Web Examples]
Part of #3928
Description
Web Examples for Python
1-hello-flask
,2-todo-flask
,3-hello-django
,4-todo-django
ExamplesRelated Issues
Checklist
Status
Require Review!!!