-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix edge cases in selective execution #4140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes handling of private tasks and added tests for that and for renaming tasks. As private tasks and overridden tasks are assigned a
.super.xyz
suffix during planning, we need to ensure we use theTerminal#render
label which includes this suffix rather than the.ctx.segments.render
label which does notEnsure we preserve all watches during
--watch
, even if some portion of the build graph was skipped due to selective execution. This ensures that inputs that were skipped can continue to be watched and still trigger downstream changes laterWe should make sure in
selective.resolve
that we do not callresolve
on the outcome ofdiffMetadata
, as that may include private tasks that cannot be resolved externally. Instead we should only callresolve
when there is no diff to be had, in which case we need to take the input selector and resolve it to concrete task names to display