Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create blog/ component in antora docsite #4151

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Dec 17, 2024

Fixes #4108

For now we move the compile-java.adoc post over there with an appropriate forwarder, and added another post Why Use a Monorepo Build Tool?. We can write more posts going forward

Comment on lines 4 to 6
:page-aliases: xref:mill:ROOT:comparisons/java-compile.adoc

_Li Haoyi, 29 November 2024_
Copy link
Member

@lefou lefou Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:page-aliases: xref:mill:ROOT:comparisons/java-compile.adoc
_Li Haoyi, 29 November 2024_
:page-aliases: xref:mill:ROOT:comparisons/java-compile.adoc
:author: Li Haoyi
:revdate: 29 November 2024

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know, it they already render as you want, but these a the default attributes to use. They are also used in document/HTML meta data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if the :author: and :revdate: attributes get shown anywhere? Otherwise we'll have to include it in the text manually anyway

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the template that Antora uses. I haven't checked yet. If you need to include it manually, you should keep the tags and refer to them with {author} and {revdate}.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up doing the {author} {revdate} thing

@lihaoyi lihaoyi marked this pull request as ready for review December 17, 2024 14:09
@lihaoyi lihaoyi merged commit 0b6caf4 into com-lihaoyi:main Dec 17, 2024
26 checks passed
@lefou lefou added this to the 0.12.4 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break out a blog/ section of the docsite
2 participants