[2/N] Add type annotations to ModelPatcher fields #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
changed the title
shawnington
reviewed
May 27, 2024
| self.model_lowvram = False | ||
| self.lowvram_patch_counter = 0 | ||
| self.patches_uuid = uuid.uuid4() | ||
| self.load_device: torch.device = load_device |
There was a problem hiding this comment.
why not just type hint load_device and offload_device in the init input only? Python isn't a typed language, and the variable are descriptive of what they are doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3564
This PR adds type annotations to
ModelPatcher's fields.This PR also makes
ModelPatchergeneric so that we can have type annotations likeModelPatcher[Unet],ModelPatcher[VAE]for easier code understanding.