Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview latent on AMD Devices for Windows. #3583

Closed
wants to merge 2 commits into from

Conversation

traugdor
Copy link

Improve Latent Preview by forcing dtype=uint8
Check if device supports non-blocking

@traugdor
Copy link
Author

Closes #3539

@dnswd
Copy link

dnswd commented May 29, 2024

Does the uint8 casting still needed after changes on device_supports_non_blocking?

@traugdor
Copy link
Author

traugdor commented Jun 1, 2024

Does the uint8 casting still needed after changes on device_supports_non_blocking?

It seems so. I was still running into issues without it, but if you can provide evidence that it's not needed on some AMD devices, then it may be worth revisiting in the future.

@traugdor
Copy link
Author

traugdor commented Jun 1, 2024

Closing in favor of commits to main repo that have addressed this issue.

@traugdor traugdor closed this Jun 1, 2024
@traugdor traugdor reopened this Jun 5, 2024
@traugdor
Copy link
Author

traugdor commented Jun 5, 2024

I am reopening this pull request because after updating ComfyUI, I am still getting this error in the latent_preview.py file:

TypeError: Cannot handle this data type: (1, 1, 3), <f4

While my code (as is) is outdated with the recent updates, uint8 needs to be enforced, especially on AMD devices or this will continue to break.

@mcmonkey4eva mcmonkey4eva marked this pull request as draft June 28, 2024 23:35
@mcmonkey4eva
Copy link
Collaborator

If this remains an issue, please repush the change to resolve the merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants