Save widget names in the workflow JSON #3625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, any external tooling will have a hard time converting workflow JSON files to the API format. The main reason is that widgets_values is an array and mapping values from that array to widget names requires loading node types from the object_info endpoint as well. However, object_info depends on the plugins installed and thus may miss some of the nodes in the workflow. This change adds widget_names to the JSON, allowing direct conversion of workflow files to API format without prior knowledge of all node types. This could also help with compatibility in the future. Resolves comfyanonymous#2275
|
litegraph modification PR should be submitted to litegraph repo. And I love this commit. |
|
Oh, I see. I didn't look at the file name, missed the facts it's a copy of a library. Will send a PR there too 👍 |
dennwc
added a commit
to dennwc/litegraph.js
that referenced
this pull request
Jun 2, 2024
|
frontend is replaced by https://github.com/Comfy-Org/ComfyUI_frontend now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any external tooling will have a hard time converting workflow JSON files to the API format.
The main reason is that
widgets_valuesis an array and mapping values from that array to widget names requires loading node types from the/object_infoendpoint as well. However,/object_infodepends on the plugins installed and thus may miss some of the nodes in the workflow.This change adds
widget_namesto the JSON, allowing direct conversion of workflow files to API format without prior knowledge of all node types. This could also help with compatibility in the future.Requires comfyanonymous/litegraph.js#10
Resolves #2275