Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the webUI History and Queue lists #3773

Closed
wants to merge 5 commits into from

Conversation

Slickytail
Copy link
Contributor

This PR updates UI code and CSS to achieve the following features for the prompt history and prompt queue lists.

  • Automatic scaling of the size of the list
  • Approximate preservation of the scroll position when the list is updated.

This second part fixes a longstanding annoying that myself and other users have noted where the scroll position is lost even when no new elements are added, as a result of the websocket refreshing the list in the background.

The preservation of scroll position is "approximate" because it does not properly add the offset from new or deleted entries after update. To really solve this problem, we'd have to reimplement a minimal version of the react dom-diffing algorithm, in order to preserve the individual dom elements themselves, and therefore the scroll anchors that the browser uses. I didn't do that, because it felt like a lot of added complexity for very little gain.

@DrJKL
Copy link
Contributor

DrJKL commented Jun 27, 2024

Could you add some screenshots?

You might also want to look into this: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_scroll_snap

@Slickytail
Copy link
Contributor Author

20240702_16h22m33s_grim
Here's a screenshot of the expanded history list. It's just longer, and it scales until the sidebar fills 90vh.

@mcmonkey4eva mcmonkey4eva added User Support A user needs help with something, probably not a bug. and removed User Support A user needs help with something, probably not a bug. labels Sep 12, 2024
@mcmonkey4eva
Copy link
Collaborator

frontend is replaced by https://github.com/Comfy-Org/ComfyUI_frontend now

@Slickytail Slickytail deleted the better-scrollbar branch September 16, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants