Add CFG++ to DPM++ 2S Ancestral #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmonkey4eva
added
the
Good PR
mainly using a dynamic rho value (hey this sounds a lot like smea!!!)
rho? r? its just 1/2
|
I wonder what's stopping this PR from merging. Tried it and it works fine for me. |
|
it probably is in the backlog, ive asked comfy in discord to check it so hopefully it gets merged now that its somewhat more up to date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this is the correct formatting, but I decided to call it
dpmpp_2s_ancestral_ppinstead of the funnierdpmpppp_2s_ancestralExample comparison v
(p.s. thank you to foxfu@tohoai for finding out how to make the conditioning work and not be swapped)