Use relative path for custom/extra node module name #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
changed the title
|
Had to revert this because it broke some imports like: import comfy_extras.nodes_model_merging |
Issue confirmed. |
|
Tested #3943 is good. Can you merge that one instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #3943
Previously the module name of imported custom node is set as filename / directoryname, which can cause potential name conflict.
Imagine you have both
comfy_extras/audio_nodes.pyandcustom_nodes/audio_nodes/. They both resolve to the same module nameaudio_nodeswhich can cause issue.This PR makes module name relative path to the ComfyUI root folder so that this situation does not happen.
I can add some unit tests if the unit test infrastructure setup in #3897 is merged.