Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadrive: use comma fork #30087

Closed
wants to merge 7 commits into from
Closed

Metadrive: use comma fork #30087

wants to merge 7 commits into from

Conversation

jnewb1
Copy link
Contributor

@jnewb1 jnewb1 commented Sep 28, 2023

prevents an extra copy that is caused by RGBA -> RGB conversion

use comma fork until we get upstream changes

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Sep 28, 2023

Let's hold off on merging this until we try to make an upstream MetaDrive PR. If we don't get a response from them in a couple days, we can merge this.

@jnewb1
Copy link
Contributor Author

jnewb1 commented Sep 28, 2023

@jnewb1 jnewb1 changed the title Metadrive: speedup rgb capture Metadrive: use comma fork Sep 29, 2023
@jnewb1
Copy link
Contributor Author

jnewb1 commented Oct 2, 2023

our upstream changes were merged so we can just update metadrive

@jnewb1 jnewb1 closed this Oct 2, 2023
@jnewb1 jnewb1 deleted the metadrive-speedup-rgb branch October 2, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants