Skip to content

Commit

Permalink
Make mkdocsBuild part of the checks on CI build. (#790)
Browse files Browse the repository at this point in the history
* remove relative links to pass mkdocsBuild.
* add ./gradlew mkdocsBuild to checks.
  • Loading branch information
ahmetoz authored Oct 1, 2021
1 parent 34e33b7 commit 0166991
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
run: ./gradlew pmdBenchmark pmdIntegrationTest pmdMain pmdTest
- name: Spotbugs
run: ./gradlew spotbugsBenchmark spotbugsIntegrationTest spotbugsMain spotbugsTest
- name: mkdocsBuild
run: ./gradlew mkdocsBuild

tests:
name: Tests
Expand Down
2 changes: 1 addition & 1 deletion docs/RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
[Jar](https://search.maven.org/artifact/com.commercetools/commercetools-sync-java/8.0.0/jar)

- 🚧 **Breaking Changes** (1)
- Removed support of changing the attribute definition type [#787](https://github.com/commercetools/commercetools-sync-java/pull/787) since removal and addition of the attribute with the same name in a single request is not possible by commercetools API anymore. For more information please [check](../docs/adr/0003-syncing-attribute-type-changes.md).
- Removed support of changing the attribute definition type [#787](https://github.com/commercetools/commercetools-sync-java/pull/787) since removal and addition of the attribute with the same name in a single request is not possible by commercetools API anymore. For more information please [check](https://github.com/commercetools/commercetools-sync-java/blob/master/docs/adr/0003-syncing-attribute-type-changes.md).

-**Enhancement** (1)
- Use the new concurrency keyword on github actions to limit the concurrency of the workflow runs. [#772](https://github.com/commercetools/commercetools-sync-java/issues/772)
Expand Down
2 changes: 1 addition & 1 deletion docs/usage/PRODUCT_TYPE_SYNC.md
Original file line number Diff line number Diff line change
Expand Up @@ -278,4 +278,4 @@ More examples of those utils for different fields can be found [here](https://gi

## Caveats
1. The order of attribute definitions in the synced product types is not guaranteed.
2. Changing the attribute definition type is not supported. Instead, remove and re-add it with a new type manually, either over API or merchant center. For more information please [check](../../docs/adr/0003-syncing-attribute-type-changes.md).
2. Changing the attribute definition type is not supported. Instead, remove and re-add it with a new type manually, either over API or merchant center. For more information please [check](https://github.com/commercetools/commercetools-sync-java/blob/master/docs/adr/0003-syncing-attribute-type-changes.md).

0 comments on commit 0166991

Please sign in to comment.