Add the app conditions error to diff comment #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzdann
commented
Sep 5, 2024
| @@ -410,6 +410,36 @@ func createTempAppObjectFroNewApp(ctx context.Context, componentPath string, rep | |||
| } | |||
| } | |||
|
|
|||
| // deleteTempAppObject deletes a temporary app object created for diff generation | |||
| // returns an error if the deletion fails | |||
| func deleteTempAppObject(ctx context.Context, ac argoCdClients, app *argoappv1.Application) error { | |||
There was a problem hiding this comment.
not happy with the temp in the function name but it's following the createTempAppObjectFroNewApp naming (which has a typo 😄 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist