Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relevant components discovery and add support for ArgoCD "native" application discovery #8

Merged
merged 16 commits into from
Jun 12, 2024
Merged

Fix relevant components discovery and add support for ArgoCD "native" application discovery #8

merged 16 commits into from
Jun 12, 2024

Commits on May 21, 2024

  1. Use telefonistka in-pr metadata mechanism to pass changed component path 

    to ArgoCD diff functionality
    @Oded-B
    Oded-B committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f18bd46 View commit details
    Browse the repository at this point in the history

  2. Add some validation to avoid auto-merging PRs in cases telefonistka is 

    unsure of the component that where changed
    @Oded-B
    Oded-B committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2a5adc2 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Support two way to fetch matching ArgoCD apps from a Telefonistka 

    component the telefonistka dedicated sha1 label and the ArgoCD native
`manifest-generate-paths`  annotation
    @Oded-B
    Oded-B committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2b76230 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Fix relevant components discovery hannes (#9) 

    * mocks: use go run to reduce dependency

Using go run will automatically install the tool and run it if it is not
installed already.

* argocd: fix import path

The import path for the mocks package is incorrect causing errors.

The mocks package should be imported from internal/pkg/mocks instead of
mocks/argocd.

This also removes the aliased import and uses the package as named,
which aligns with the directory name.

---------

Co-authored-by: Hannes Gustafsson <hannes.gustafsson@commercetools.com>
    @Oded-B @hnnsgstfssn
    Oded-B and hnnsgstfssn authored May 30, 2024
    Configuration menu
    Copy the full SHA
    8a157ff View commit details
    Browse the repository at this point in the history

  2. Add needed argodiff.NewDiffConfigBuilder param (after version upgrade) 

    Log time of API call with questionable performance :)
    @Oded-B
    Oded-B committed May 30, 2024
    Configuration menu
    Copy the full SHA
    7a52552 View commit details
    Browse the repository at this point in the history

  3. Fix typo and add code generate step to makefile

    @Oded-B
    Oded-B committed May 30, 2024
    Configuration menu
    Copy the full SHA
    0e579b1 View commit details
    Browse the repository at this point in the history

  4. Lint fixes, fix gitignore. 

    upsate go.mod
    @Oded-B
    Oded-B committed May 30, 2024
    Configuration menu
    Copy the full SHA
    e6c120c View commit details
    Browse the repository at this point in the history

  5. Hack go genrate for linting

    @Oded-B
    Oded-B committed May 30, 2024
    Configuration menu
    Copy the full SHA
    29e72b0 View commit details
    Browse the repository at this point in the history

  6. Cleanup and try to use make file config

    @Oded-B
    Oded-B committed May 30, 2024
    Configuration menu
    Copy the full SHA
    a9ab829 View commit details
    Browse the repository at this point in the history

  7. Document new configuration key

    @Oded-B
    Oded-B committed May 30, 2024
    Configuration menu
    Copy the full SHA
    03b61cc View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge branch 'main' into fix_relevant_components_discovery

    @Oded-B
    Oded-B authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    025adbf View commit details
    Browse the repository at this point in the history

  2. Update argocd_test.go - remove some editor completion artifacts

    @Oded-B
    Oded-B authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    0c25bc9 View commit details
    Browse the repository at this point in the history

  3. Fix two "bad conflict resolution" issues

    @Oded-B
    Oded-B committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    b35fdff View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Yazdan Mohammadi <yzdannn@gmail.com>
    @Oded-B @yzdann
    Oded-B and yzdann authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    134d7c3 View commit details
    Browse the repository at this point in the history

  5. I fix var name typo

    @Oded-B
    Oded-B committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    fc1df93 View commit details
    Browse the repository at this point in the history

  6. Rename client var names

    @Oded-B
    Oded-B committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    6861102 View commit details
    Browse the repository at this point in the history