Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): update ejs to version 2.5.9 #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(package): update ejs to version 2.5.9 #34

wants to merge 2 commits into from

Conversation

gregswindle
Copy link
Contributor

@gregswindle gregswindle commented Apr 21, 2018 •
edited
Loading

Pull Request (PR)

Description of change

Update ejs to version 2.5.9.

Associated issue(s)

Closes #31

  • The acceptance criteria for all associated issues have been completed, tested, and validated.

PR check-list

✅ Please review and check the appropriate items.

1. Code standards compliance

JavaScript Style Guide

  • ESLint passes.

2. Code quality Quality Gate

  • The quality gateways pass with an "A" grade.
Measure Scores
Complexity Complexity
Cognitive complexity
Complexity per Class
Complexity per file
Complexity per Function
Duplications Duplications
Issues Issues
Maintainability Code smells
Maintainability
Technical debt
Reliability Reliability
Security Security

3. Test coverage Coverage Status

  • The source code is 100% covered with passing specs.

ℹ️ These tasks are not required to open a PR, and may be addresses while the PR is open.

@gregswindle gregswindle self-assigned this Apr 21, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0088b1a on greenkeeper/ejs-2.5.9 into fc5c048 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0088b1a on greenkeeper/ejs-2.5.9 into fc5c048 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0088b1a on greenkeeper/ejs-2.5.9 into fc5c048 on master.

@coveralls
Copy link

coveralls commented Apr 21, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 0088b1a on greenkeeper/ejs-2.5.9 into fc5c048 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregswindle gregswindle

Labels
priority: low type: fix type: test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregswindle @coveralls