Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary security group rules for on-premise frontends #56

Open
wants to merge 1 commit into
base: infrastructure
Choose a base branch
from
Open

Remove temporary security group rules for on-premise frontends #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions groups/frontend/instance.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,6 @@ resource "aws_security_group" "services" {
}
}

# TODO Remove this; this was added for testing Tuxedo services in live using on-premise frontend services
dynamic "ingress" {
for_each = var.environment == "live" || var.environment == "staging" ? each.value : {}
iterator = service
content {
description = "Allow client requests from on-premise frontend web servers to ${service.key} service in ${each.key} server group"
from_port = service.value
to_port = service.value
protocol = "TCP"
cidr_blocks = var.on_premise_frontend_cidrs
}
}

dynamic "ingress" {
for_each = each.value
iterator = service
Expand Down
7 changes: 0 additions & 7 deletions groups/frontend/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,6 @@ variable "lvm_block_devices" {
default = []
}

# TODO Remove this; this was added for testing Tuxedo services in live using on-premise frontend services
variable "on_premise_frontend_cidrs" {
type = list(string)
description = "A list of strings representing the CIDR ranges for on-premise frontend services"
default = []
}

variable "region" {
type = string
description = "The AWS region in which resources will be administered"
Expand Down