This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Use new opensees Python package
#128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvanmele
reviewed
Sep 13, 2024
requirements-dev.txt
Outdated
| @@ -16,4 +16,5 @@ pytest >=3.2 | |||
| sphinx_compas_theme >=0.13 | |||
| sphinx >=3.4 | |||
| twine | |||
| opensees>=0.1.0 | |||
There was a problem hiding this comment.
only requirements related to package development should be listed here...
| @@ -1 +1,2 @@ | |||
| COMPAS >=1.0 | |||
| opensees>=0.1.0 | |||
There was a problem hiding this comment.
this should indeed be an optional dependency since it is not compatible with Rhino 7
|
hi, just FYI, also note, that |
|
Thanks for looking over this. I wasn't aware of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a great project you have! It would be invaluable if I could incorporate the Compas project into my research, but I would need it to support the newer
openseesPython package interface to OpenSees. To this end I've added this as an option inopensees.launch_process. I think this will also streamline installation/configuration, as theopenseesPython package is simply added to the package dependencies. However, it may be preferable to weaken this to only an optional dependency; let me know if you prefer this!