Remove conda forge channel from xeus-cpp wasm host environment #214
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 19 19
Lines 970 970
Branches 93 93
=======================================
Hits 783 783
Misses 187 187 |
| @@ -1,11 +1,10 @@ | |||
| name: xeus-cpp-wasm-host | |||
| channels: | |||
| - https://repo.mamba.pm/emscripten-forge | |||
| - https://repo.mamba.pm/conda-forge | |||
There was a problem hiding this comment.
Hmmm, looks good to me but I think this ended up here for a reason. Let me confirm on the xeus side and get back.
There was a problem hiding this comment.
@anutosh491 Ok. Just a note that CppInterOps environment only references emscripten-forge.
|
Ahh I finally think I remember why we need this (and probably why we should keep it) It is there to support no-arch packages. We currently don't provide any extra functionality as we are in the initial stage of things. But take xeus-r for example (https://github.com/jupyter-xeus/xeus-r/blob/main/environment-wasm-host.yml#L18-L29) provides so many libraries for graphics, image rendering etc. So in future we might want to add features where packages might be no-arch. Let's just keep this ! |
Description
Please include a summary of changes, motivation and context for this PR.
When we call the wasm environment we call it under the emscripten-wasm32 platform which doesn't exist for the conda forge channel. As a result we get the following error in the build
https://github.com/compiler-research/xeus-cpp/actions/runs/12723529061/job/35468733198?pr=213#step:7:51 . Removing the reference to the conda-forge channel fixes this.
Fixes # (issue)
Type of change
Please tick all options which are relevant.