Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Method of zero_like_rdata_from_type #279

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Oct 2, 2024

I'm opening this as an easy way to run the entire test suite to see what fails when I remove this. Do not merge.

update: this actually can be merged -- it looks like these method were redundant. They don't make any sense anyway because a TypeVar is not a type, so they really ought not to exist. I'll update, bump the patch, and merge when CI passes.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/interpreter/zero_like_rdata.jl 100.00% <ø> (ø)

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬─────────┬─────────────┬─────────┐
│                      Label │ Mooncake │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │  String │      String │  String │
├────────────────────────────┼──────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │    116.0 │     1.0 │         5.1 │     1.9 │
│                  _sum_1000 │     7.97 │  1430.0 │        40.3 │   0.126 │
│               sum_sin_1000 │    0.917 │   0.581 │         4.2 │    0.37 │
│              _sum_sin_1000 │     1.23 │   129.0 │        7.37 │   0.602 │
│                   kron_sum │     60.6 │    10.1 │       195.0 │    11.4 │
│              kron_view_sum │     81.5 │    11.3 │       212.0 │    12.4 │
│      naive_map_sin_cos_exp │     2.41 │ missing │        7.38 │    2.15 │
│            map_sin_cos_exp │     4.79 │    1.73 │        7.57 │    3.14 │
│      broadcast_sin_cos_exp │     4.23 │    2.56 │        1.68 │    2.84 │
│                 simple_mlp │     8.48 │    3.26 │        12.6 │    3.32 │
│                     gp_lml │     17.0 │    6.62 │     missing │ missing │
│ turing_broadcast_benchmark │     7.16 │ missing │        31.2 │ missing │
│         large_single_block │     3.81 │  4340.0 │        30.1 │    2.17 │
└────────────────────────────┴──────────┴─────────┴─────────────┴─────────┘

@willtebbutt
Copy link
Member Author

It looks like this actually could be merged. I'll do so once #254 has been merged in.

@willtebbutt willtebbutt changed the title [Do not merge] Remove Method of zero_like_rdata_from_type Remove Method of zero_like_rdata_from_type Oct 4, 2024
@willtebbutt willtebbutt merged commit 534fc19 into main Oct 4, 2024
17 checks passed
@willtebbutt willtebbutt deleted the wct/try-out-removing-method branch October 4, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant