Fix IP spoofing and invalid URI errors #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslzhu
approved these changes
Aug 17, 2019
|
omg shorter branch names pls @jvperrin |
|
Thanks for merging, I've been out this weekend (and yesterday) so not around a machine to actually deploy changes easily |
ochan1
pushed a commit
to ochan1/hkn-rails
that referenced
this pull request
Feb 10, 2022
* added some comments * made serv app * Finished serv static pages * applying black formatter * fixing small things, fixing the url bug that @conhuang mentioned Co-authored-by: bri25yu <bri25yu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been noisy and not actionable, so let's fix them so we stop getting spammed via email about them!
Fixes #197 (and helps with some of #173)
Note that some URIs still do produce errors, but it's much fewer than before, since the URI encoding thing fixes most of them.