-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown Security Patch #280
Conversation
Copy over current progress to Oscar
Pull from Andrew to Oscar (file upload working)
Into Oscar Exams temp branch
Exams oscar to the master in oscar's fork
hkn web changes
Pull main CompServ to ochan1
The original bug from this branch: Used patch from neutronX/django-markdownx#163 |
All "markdownify" function calls shall need to be called from the one made in "hknweb.utils" for security purposes |
There is no need to modify the backend data, but if any malicious HTML code is pushed, it will stay on the backend However, before showing up to the end-user, the text is sanitized |
…into eventsMarkdownPatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tried to inject various alerts and images into event descriptions and urls, which all did not succeed. Markdownify being added as a dependency seems like a worthwhile trade for the security and access to markdown.
No description provided.