Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Security Patch #280

Merged
merged 36 commits into from
Jan 3, 2021
Merged

Markdown Security Patch #280

merged 36 commits into from
Jan 3, 2021

Conversation

ochan1
Copy link
Contributor

@ochan1 ochan1 commented Jan 1, 2021

No description provided.

AndrewKe and others added 30 commits April 5, 2020 17:40
Copy over current progress to Oscar
Pull from Andrew to Oscar (file upload working)
Into Oscar Exams temp branch
Exams oscar to the master in oscar's fork
Pull main CompServ to ochan1
@ochan1
Copy link
Contributor Author

ochan1 commented Jan 1, 2021

The original bug from this branch:
#266

Used patch from neutronX/django-markdownx#163

@ochan1
Copy link
Contributor Author

ochan1 commented Jan 1, 2021

All "markdownify" function calls shall need to be called from the one made in "hknweb.utils" for security purposes

@ochan1
Copy link
Contributor Author

ochan1 commented Jan 1, 2021

There is no need to modify the backend data, but if any malicious HTML code is pushed, it will stay on the backend

However, before showing up to the end-user, the text is sanitized

@ochan1 ochan1 changed the title Events markdown patch Markdown Security Patch Jan 1, 2021
Copy link
Contributor

@sammaher1 sammaher1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tried to inject various alerts and images into event descriptions and urls, which all did not succeed. Markdownify being added as a dependency seems like a worthwhile trade for the security and access to markdown.

@ochan1 ochan1 merged commit 48f2768 into compserv:master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants