Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Exercise #573

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hknweb/events/forms/event/create.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class Meta:
model = Event
fields = (
"name",
"point_of_contact",
"location",
"description",
"event_type",
Expand Down
16 changes: 16 additions & 0 deletions hknweb/events/migrations/0013_alter_icalview_options.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Generated by Django 4.2.11 on 2024-03-16 05:18

from django.db import migrations


class Migration(migrations.Migration):
dependencies = [
("events", "0012_icalview"),
]

operations = [
migrations.AlterModelOptions(
name="icalview",
options={"verbose_name": "iCal view"},
),
]
17 changes: 17 additions & 0 deletions hknweb/events/migrations/0014_event_point_of_contact.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Generated by Django 4.2.11 on 2024-03-16 05:26

from django.db import migrations, models


class Migration(migrations.Migration):
dependencies = [
("events", "0013_alter_icalview_options"),
]

operations = [
migrations.AddField(
model_name="event",
name="point_of_contact",
field=models.CharField(default="N/A", max_length=255),
),
]
1 change: 1 addition & 0 deletions hknweb/events/models/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

class Event(models.Model):
name = models.CharField(max_length=255)
point_of_contact = models.CharField(max_length=255, default="N/A")
start_time = models.DateTimeField()
end_time = models.DateTimeField()
location = models.CharField(max_length=255)
Expand Down
1 change: 1 addition & 0 deletions hknweb/events/views/event_transactions/show_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def show_details_helper(request, id, back_link: str, can_edit: bool):

context = {
"event": event,
"event_point_of_contact": markdownify(event.point_of_contact),
"event_description": markdownify(event.description),
"event_location": format_url(event.location),
"user_access_level": ACCESSLEVEL_TO_DESCRIPTION[get_access_level(request.user)],
Expand Down
20 changes: 19 additions & 1 deletion hknweb/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,13 +206,15 @@ def email_to_username(email: str) -> str:

# Get existing usernames
usernames = []
emails = []
invalid_emails = []
for row in rows:
email = row["Berkeley email"]
username = email_to_username(email)

if username:
usernames.append(username)
emails.append(email)
else:
invalid_emails.append(email)

Expand All @@ -224,6 +226,12 @@ def email_to_username(email: str) -> str:
)
)

existing_emails = set(
User.objects.filter(email__in=emails).values_list(
"email", flat=True
)
)

# Setup account provisioning utils
# Get candidate group to add users to
group = Group.objects.get(name=settings.CAND_GROUP)
Expand All @@ -237,9 +245,14 @@ def generate_password() -> str:
return password

email_information = []
skipped_rows = []
for row in rows:
# If username is None or already exists, skip provisioning
if (row["username"] is None) or (row["username"] in existing_usernames):
skipped_rows.append(row)
continue
if ((row["Berkeley email"] is None) or (row["Berkeley email"] in existing_emails)):
skipped_rows.append(row)
continue

# Generate a password
Expand All @@ -250,7 +263,7 @@ def generate_password() -> str:
username=row["username"],
first_name=row["First name"],
last_name=row["Last name"],
email=row["Berkeley email"],
email=row["Berkeley email"].lower(),
password=password,
)
user.save()
Expand All @@ -260,8 +273,13 @@ def generate_password() -> str:

# Add information for sending emails
email_information.append((user, password))
existing_usernames.add(row["username"])
existing_emails.add(row["Berkeley email"].lower())

self.email_information = email_information

# Save information for adding messages
self.invalid_emails = invalid_emails

for row in skipped_rows:
print(row)
1 change: 1 addition & 0 deletions hknweb/templates/events/show_details.html
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ <h1 id="event-detail-title"> {{ event.name }} </h1>
<div id="left-details">

<p>{{ event_description | safe }}</p>
<p><b>Point of Contact</b>: {{ event.point_of_contact}}</p>
<p><b>Event Type</b>: {{ event.event_type }}</p>
<p><b>Location</b>: {{ event_location }}</p>
<p><b>Date(s) and Time(s)</b>: {{ event | process_event_time }}</p>
Expand Down
949 changes: 479 additions & 470 deletions poetry.lock

Large diffs are not rendered by default.

11 changes: 11 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
bleach==6.1.0
dal==0.2
djangorestframework==3.14.0
Fabric==3.2.2
google_api_python_client==2.122.0
icalendar==5.0.11
invoke==2.2.0
Markdown==3.6
protobuf==5.26.0
pytz==2024.1
Requests==2.31.0