Skip to content

Commit

Permalink
Merge branch 'gh579'
Browse files Browse the repository at this point in the history
  • Loading branch information
kordejong committed Sep 12, 2023
2 parents 23a5cfe + e518b3b commit c085272
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 17 deletions.
3 changes: 0 additions & 3 deletions source/data_model/python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ target_compile_definitions(lue_py_data_model

set_target_properties(lue_py_data_model
PROPERTIES
RUNTIME_OUTPUT_DIRECTORY $<TARGET_FILE_DIR:lue::py>
CXX_CLANG_TIDY "" # TODO(KDJ) Get it to skip pybind11.h
)

Expand All @@ -117,8 +116,6 @@ target_link_libraries(lue_py_data_model
nonstd::span-lite
)

pybind11_extension(lue_py_data_model)

# TODO pybind11_strip does not work on macOS, when building using Conda packages
# The resulting binary can't be imported. Results in "killed: 9".
if(NOT MSVC AND NOT APPLE AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo)
Expand Down
7 changes: 0 additions & 7 deletions source/framework/python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,6 @@ target_compile_definitions(lue_py_framework
NPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION
)

set_target_properties(lue_py_framework
PROPERTIES
RUNTIME_OUTPUT_DIRECTORY $<TARGET_FILE_DIR:lue::py>
)

target_include_directories(lue_py_framework
PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/../../data_model/python/include
Expand All @@ -183,8 +178,6 @@ target_link_libraries(lue_py_framework
pybind11::windows_extras
)

pybind11_extension(lue_py_framework)

# TODO pybind11_strip does not work on macOS, when building using Conda packages
# The resulting binary can't be imported. Results in "killed: 9".
if(NOT MSVC AND NOT APPLE AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo)
Expand Down
7 changes: 0 additions & 7 deletions source/qa/python/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ if(LUE_QA_WITH_PYTHON_API)

add_library(lue::py_qa ALIAS lue_py_qa)

set_target_properties(lue_py_qa
PROPERTIES
RUNTIME_OUTPUT_DIRECTORY $<TARGET_FILE_DIR:lue::py>
)

target_include_directories(lue_py_qa
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
Expand All @@ -32,8 +27,6 @@ if(LUE_QA_WITH_PYTHON_API)
pybind11::windows_extras
)

pybind11_extension(lue_py_qa)

# TODO pybind11_strip does not work on macOS, when building using Conda packages
# The resulting binary can't be imported. Results in "killed: 9".
if(NOT MSVC AND NOT APPLE AND NOT ${CMAKE_BUILD_TYPE} MATCHES Debug|RelWithDebInfo)
Expand Down

0 comments on commit c085272

Please sign in to comment.