Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh608 #631

Merged
merged 14 commits into from
Apr 4, 2024
Merged

Gh608 #631

merged 14 commits into from
Apr 4, 2024

Conversation

OliverSchmitz
Copy link
Member

both macOS builds work
both Conda macOS reach the known segfault

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commenting of of conda.yml should be undone again, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think so

Copy link
Member

@kordejong kordejong Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you maybe still have this link about HDF5 misbehaving on this platform? Whenever possible we should get rid of the downgrade of HDF5 again. Maybe there is a ticket to track somewhere? Adding the link in this file would be useful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a 'broken hdf5 1.14' link in the yaml
I don't know enough about brew what their upgrade strategy is, I think the hdf is still broken
perhaps a ticket, and rechecking this when brew hdf5 1.14.4 available?

@kordejong kordejong self-assigned this Mar 28, 2024
@kordejong
Copy link
Member

Thanks for the PR! I would like the C/I build to also be shown here. Not sure how that works, but I update the workflow scripts to also trigger upon the pull_request trigger. Can you maybe rebase your branch on the updated master and see whether that indeed triggers the builds? Might require some fine-tuning still.

@kordejong
Copy link
Member

It works! Great. But, I broke the lue_consume build. This build is normally excluded but it is now triggered. I will fix this in LUE's master.

@kordejong
Copy link
Member

Remaining issues are not related to the changes made here.

@kordejong kordejong merged commit 955a2e0 into computationalgeography:master Apr 4, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants