Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue 158 #159

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

ajogseneca
Copy link
Contributor

Additions

  • Added test cases with the help of python and selenium.
  • Make sure to have python installed and selenium . It can be installed with pip install selenium

Test checks

Test functions include :

  • def test_title_input_updates_preview(driver) : It checks if the user inputed title is getting added to the form and also visible in the preview button.
  • def test_content_input_updates_preview(driver) : It checks if the user inputed content of the blog is read by the form and also visible to the user when the preview button is pressed.
  • def test_image_upload_and_preview(driver) : It checks if the file upload for the blog cover works, that is if the image is getting loaded in the form or not.
  • def test_preview_toggle(driver) : This case checks if the preview button is working or not.

Copy link

netlify bot commented Dec 7, 2024

Deploy Preview for dainty-scone-61e301 ready!

Name Link
🔨 Latest commit 934f687
🔍 Latest deploy log https://app.netlify.com/sites/dainty-scone-61e301/deploys/6759ee090b92710008fcc8b8
😎 Deploy Preview https://deploy-preview-159--dainty-scone-61e301.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@gaurovgiri gaurovgiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, you last three PRs are related to same feature but unfortunately, these seemed a bit out of our plans for now.

@gaurovgiri
Copy link
Contributor

Let me know others thought on this and then we can proceed to approval

@ajogseneca
Copy link
Contributor Author

ajogseneca commented Dec 11, 2024

Changes

Concern

Google Forms' won't allow embedded link if there is a file upload present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants