Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra function wrap #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

unional
Copy link

@unional unional commented Jul 18, 2016

Fix #169

System.import() returns a promise.
.then() accepts a promise in return, not a function.

@aviary-wf
Copy link

Raven

Number of Findings: 0

@unional
Copy link
Author

unional commented Jul 18, 2016

karma.start() was being called automatically when certain time has passed, not from this line:
https://github.com/Workiva/karma-jspm/blob/master/src/adapter.js#L65

If you added console.log('karma.start())` to it, you can see it is not being called.

This is because after the first call, the promiseChain resolved to a function with other System.import() calls, so they are "detached" and not tracked.

@3cp
Copy link

3cp commented Aug 14, 2017

Why there is no follow up for this much needed fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants