-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost v1.86.0: add process library #25388
boost v1.86.0: add process library #25388
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 2943d10boost/1.84.0@#c34fffae9e4aaf55c66df7a4a30d894f
boost/1.83.0@#ca296b4c22d1651ce963368efb3a911d
boost/1.72.0@#4d649765e0abc0e5557c95baa05ff4cc
boost/1.79.0@#1df9f39b9de84a0bc9310fd666658949
boost/1.85.0@#669f48f6fa69e5fd6918c7019ea1c41d
boost/1.78.0@#30cfbea560760ae9d3e7d9eba162e9d7
boost/1.75.0@#589b208e076b402c11aa9a36d24dbb55
boost/1.71.0@#16a13076db6ce8efee6d594ed4403db0
boost/1.74.0@#d26bf1f59bfd84b31e4d82a6d0f44f27
|
Uhm... I guess the link error could be fixed with something like if (WIN32)
target_link_libraries(executable ntdll)
endif() But I don't know whether this error is a symptom of another issue happening upstream (e.g. a link flag missing in Boost.Asio). Unfortunately I do not daily run Windows and do very little development on it, so I am not sure what's the best way forward here. EDIT: Maybe I've found the issue. See boostorg/process@8b3e902#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR60. |
85bce58
to
dd6b9ac
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit fc13da2boost/1.81.0@#69c544d74f624f09bc9ee76fec928d7b
boost/1.86.0@#b74f189c370a7d1e87267d3171e89b19
boost/1.78.0@#19539190211ef73849c9c9c269e45fe4
boost/1.79.0@#533877a0dbcec001a20fe0a6e4f3db49
boost/1.85.0@#ff6f1732f7069d6155e52df978a920f8
boost/1.84.0@#0d4469d72ba128d005fce7af1919cbc5
boost/1.82.0@#ca9259eb89db46283c6d063c078e379d
boost/1.83.0@#f2e3df436241926375df2eb31ebf85db
boost/1.80.0@#b30239b3ccfc136abbf6dada588c8195
boost/1.75.0@#01bd1cb688c65bb058163d156402555a
boost/1.73.0@#cae8dcfd47d9026504a92f0049ed6df0
boost/1.76.0@#39e7bb82f1ba14d9b7af728fe6422bb3
boost/1.74.0@#31e7e1acacf0ff8f072fa0e292cddc49
boost/1.72.0@#63d712c14c257171ca1b211e11dad936
boost/1.71.0@#4735689c7444d5b7e4ec7fe8a6fa7e8a
|
@robomics Thank you for providing this hotfix. I was about to check it! Tell me if you need any help. 😄 |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 6b83ca6boost/1.73.0@#07fd650306db4984b4a0182cd7fef32b
boost/1.83.0@#be8126a877959ec5877459a7d52a8dc4
boost/1.86.0@#83128cf58dae1d199fce5b42c95418c5
boost/1.79.0@#9aca49cf9cd35a85335f5665c38f6e26
boost/1.84.0@#9f55a114156099a9721376bb335a5ac3
boost/1.77.0@#59188710e3c2fe2cefca9c747d56b7e2
boost/1.78.0@#dc68668de11f6d8ef739ff6fe73add86
boost/1.81.0@#24414c86bafb732c3541ee3d93b7dbb6
boost/1.80.0@#c4d11f3cc7416bb539f3c5acf4b8707c
boost/1.72.0@#924f41ae6b955fd36c4e16d39b67ba83
boost/1.76.0@#24513ab4ad4c64c147c10bf85a26d9fe
boost/1.75.0@#f1c7c5c3393ef8fcaed095fe329ca009
boost/1.74.0@#63e126b5c9e237324e8c650beb247af2
boost/1.71.0@#bd9c1b8f03c0e9fc944431a2afea0037
|
f1d6c12
to
c2c688d
Compare
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit c2c688dboost/1.86.0@#19e46487aff56614394c8c4a9708cc28
boost/1.84.0@#2f42b988f3d91b3549025ff08b34b22b
boost/1.85.0@#0a7801fb8f369c94f2174c467340fb2b
boost/1.82.0@#387b91bfb9a9850c255f8aafad38987b
boost/1.75.0@#dcfe362dbe84d4efe9b5e17b716629d1
boost/1.81.0@#80f5dfa0034fb9924bab6d13b8915a32
boost/1.83.0@#de51031e5e7c34b09140c70aa47389ad
boost/1.73.0@#320aaa911f10b319f612aaaff98b44a0
boost/1.77.0@#baa0f06d07002bcc29a54685dd09f864
boost/1.78.0@#80d2f0be967435617ae413058c9b2e49
boost/1.74.0@#87cddc7e1c910f1590361482353a5a71
boost/1.72.0@#a7255237ef11993b9a2fe8455a31cdc0
boost/1.76.0@#9da5ba7a4d7ba6e075ec9a3c7c2dccd1
boost/1.71.0@#5036a7821a40d8b93dbda92fb69e28ee
boost/1.79.0@#eb281ca1093736fa29092c0405ff361c
boost/1.80.0@#ff19d9a8d735828acc9d625448b36a8b
|
@uilianries I have a good news and a bad news. The good news is that I figured out the issue with the Windows builds. The bad news is that the solution I found is not in line with what is done by upstream. Upstream defines Defining To me it looks like the |
@robomics Thank you for your deep investigation! Really interesting case! I see you used those CMakeList.txt files as reference. Please, understand that we do not use CMake to build boost and it's not officially supported (https://github.com/boostorg/cmake?tab=readme-ov-file#boost-cmake-support-infrastructure). So you should always check bjam files first and consider them as source of truth when building, because any difference between those files may lead you to a build trap. I see in the official bjam file, it's exposed Have you tried defining only |
@uilianries, yes defining |
@robomics Thank you for checking it previously. I'm looking into it right, it seems be a bug, but with a suggested fix: boostorg/process#409 I'll test locally on my Windows machine first, in case working, I'll send my changes to this PR. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
I would prefer disabling Boost.Process for 1.86.0 when building on Windows + Shared instead of applying that patch. However, the recipe uses no-copy-source and will not allow us customizing the option value The current error is reported already here: boostorg/process#408 |
I'm not sure whether this should be done in this PR or in separate one. Boost process allows choosing between std::filesystem and boost::filesystem There is already option in boost recipe "filesystem_use_std_fs" that switches usage to std::filesystem for some boost headers (boost::dll). From name of the option I would assume that it should also affect boost process. |
@Nekto89 A separated one, please. You could open an issue asking that feature in case you need it. I would not add in case not really required, as boost has several options already. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 972fe1dboost/1.83.0@#768bb4aba0acde3461e1e84d563d0121
boost/1.84.0@#bcd346072758a871c880b3b5db0bd21d
boost/1.86.0@#c64b8f3bf18fd973613b311bc8da981b
boost/1.85.0@#09f8a608608c12773e1ea10719ab26f8
boost/1.82.0@#77542eafd42f2d162d895aba1d3efb96
boost/1.79.0@#10937461847ea137834d7819147ef329
boost/1.81.0@#9c6ec775aa9374d5bab0acab2eef6b52
boost/1.72.0@#4a13e41a45c8ce3d983f3b979ec1f0d2
boost/1.78.0@#cd6aa08424dc864714a01dc50bf38524
boost/1.80.0@#e44a8894f42c02af6fe58251f4732e4f
boost/1.75.0@#6a7e874c2b23737b6b536148dc99b5e8
boost/1.77.0@#8e5bb0ed38006a10579b115b44f8ea63
boost/1.74.0@#8e35e5d1610ae61410567e473515c6ef
boost/1.76.0@#188583734f510c1306f25aeae95ea5ae
boost/1.71.0@#59412557f5c41a5af3c033bcfec330ad
boost/1.73.0@#eb7f116857e41bb376157e010731a4fc
|
A second option would be disabling Boost Process on Windows, but only for 1.86.0. Who is needing process, would need to enable it manually:
And we would need only this:
In terms of CI and maintenance looks much simpler, but for users will be worst as need to enable an option that's working already when building as static library. |
This reverts commit dc05670.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
After talking to @AbrilRBS it looks more correct sacrificing Boost.Process on 1.86.0, as we have no sure from the author about the proposed PR. And we strict avoid patch projects, only as last resource, and Boost is even more controlled as it affects more users. I believe it will be fixed for 1.87.0, but meanwhile, you can use |
Thanks for looking more in to this @uilianries! |
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 12 (
Conan v2 pipeline ✔️
All green in build 13 (
|
Hooks produced the following warnings for commit 668ccf8boost/1.79.0@#012e8bf5d44e8ab0cea4a7bdbd04ae26
boost/1.85.0@#3add30047e4245e29efe86ba14014e76
boost/1.83.0@#824266b91aab4ccba92e76bac65a7612
boost/1.84.0@#a73b3f530f8f544883bcb07fa9859c40
boost/1.86.0@#cd839a2082585255010f9e82eea94c7f
boost/1.82.0@#a379246d83d09536a3a1bc96c6ffc153
boost/1.77.0@#e158d636c533c1265902fc944c056f85
boost/1.81.0@#68d508874321d9244034e7306d1d6af0
boost/1.78.0@#aa49e312f0893b714f449ba518cdb6f4
boost/1.73.0@#435bb513106f6ed1bf1bf606b008b93e
boost/1.80.0@#c3ef1544fdd632f4902e1401b3ad0dec
boost/1.76.0@#194574afe1c81d38997f4cf8897f0222
boost/1.74.0@#53f1cec68f57872cb4173e7edd3034bf
boost/1.75.0@#80eb4731a1938bc2678412acca777777
boost/1.72.0@#c4cc94c3e253aff94877dcaaffb515cc
boost/1.71.0@#56a29963d7c60a6d28f3c162c695bfc2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Changes to recipe: boost/1.86.0
In Boost v1.86.0
boos.process
v2 was turned into a compiled library (see changelog).This PR adds
process
to the list of dependencies and adds tests for the new library component.Motivation
Details