Keep sessions around between each ConanRequester #17455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid creating a new session for each ConanRequester instance, this helps a lot with performance, as it avoids the overhead duplicate handshakes
memsharded
reviewed
Dec 12, 2024
memsharded
reviewed
Dec 13, 2024
AbrilRBS
commented
Dec 19, 2024
AbrilRBS
commented
Dec 23, 2024
memsharded
reviewed
Dec 23, 2024
memsharded
approved these changes
Dec 23, 2024
franramirez688
approved these changes
Dec 27, 2024
memsharded
reviewed
Dec 27, 2024
| @@ -31,6 +32,8 @@ def __init__(self, conan_api): | |||
| self.conan_api = conan_api | |||
| self._home_folder = conan_api.home_folder | |||
| self._remotes_file = HomePaths(self._home_folder).remotes_path | |||
| # Wraps an http_requester to inject proxies, certs, etc | |||
| self._requester = ConanRequester(self.conan_api.config.global_conf, self.conan_api.cache_folder) | |||
There was a problem hiding this comment.
We need to design, implement and document properly the "invalidating" and reloading of global.conf, like the requester will not get new conf after a config install. I think this is perfectly good as default, but the "invalidation" should also be doable and documented. I'll create a ticket for this later.
| self._url_creds = _SourceURLCredentials(cache_folder) | ||
| self._max_retries = config.get("core.net.http:max_retries", default=2, check_type=int) |
There was a problem hiding this comment.
The _max_retries is now legacy?
|
After internal testing on Conan Center Index, this has reduced some cases of build-order calculations from 45 mins to 10. |
memsharded
pushed a commit
to memsharded/conan
that referenced
this pull request
Jan 15, 2025
* Keep sessions around between each ConanRequester Avoid creating a new session for each ConanRequester instance, this helps a lot with performance, as it avoids the overhead duplicate handshakes * Patch new cached value on ConanRequester tests * Modify adapter as needed * Fix tests * Name * Update conans/client/rest/conan_requester.py * Refactor requester tests * Reinit is not part of this PR * Refactor request usage out of app * Make max_retries a local variable
memsharded
added a commit
that referenced
this pull request
Jan 21, 2025
* extra patches path * Update conan/tools/files/patches.py Co-authored-by: Andrey Filipenkov <kambaladecapitator@gmail.com> * fix docstring of Environment.vars() (#17521) fix docstring of vars() * GnuToolchain's make_args handle empty values correctly (#17532) test * Change replace_in_file to return True on success (#17531) - was inconsistent before: returned False if the pattern was not found (with strict off), otherwise None * upgrade bottle version (#17534) * better traces and msgs (#17517) * better traces and msgs * fix tests * Feature/workspace api (#17501) * working in workspace_api * fixed loader + run() error * update webtest testing version (#17537) * proposing new --format=<format> --out-file=<file.ext> feature (#17507) * proposing new --format=file.ext feature * change approach and some simplifications * remove unused * minor changes * minor changes * simplify a bit * fix format * minor changes * fix * move colorama deinit/reinit * add out-file only if formatters * revert * wip * do not deinit/reinit if not tty * clean import * minor changes --------- Co-authored-by: czoido <mrgalleta@gmail.com> * Test/remote login (#17552) * new test for remote_login * unittest->pytest * Keep sessions around between each ConanRequester (#17455) * Keep sessions around between each ConanRequester Avoid creating a new session for each ConanRequester instance, this helps a lot with performance, as it avoids the overhead duplicate handshakes * Patch new cached value on ConanRequester tests * Modify adapter as needed * Fix tests * Name * Update conans/client/rest/conan_requester.py * Refactor requester tests * Reinit is not part of this PR * Refactor request usage out of app * Make max_retries a local variable * Add rest of posible `ConanBasicApp` usages (#17555) Add rest of posible ConanBasicApp usages * Improve typing information in remove sub API (#17564) As the API actually accepts the remote to be `None`, this should also be reflected in the type information in order to support users. * small refactor to PkgConfigDeps (#17568) * Updated to use maxsplit=1 (#17571) * Updated to use maxsplit=1 * Add tests, unquote paths with spaces --------- Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es> * refactor moving model conans->conan (#17572) * refactor moving model conans->conan * fix tests * allow non trim_conandata * removed print --------- Co-authored-by: Andrey Filipenkov <kambaladecapitator@gmail.com> Co-authored-by: Andrey Filipenkov <decapitator@ukr.net> Co-authored-by: Ernesto de Gracia Herranz <ernestodgh@jfrog.com> Co-authored-by: mrbean-bremen <mrbean-bremen@users.noreply.github.com> Co-authored-by: czoido <mrgalleta@gmail.com> Co-authored-by: Abril Rincón Blanco <rubenrb@jfrog.com> Co-authored-by: Martin Lambertsen <github@lambertsen.one> Co-authored-by: maitrey <maitreymishra23@gmail.com> Co-authored-by: Abril Rincón Blanco <git@rinconblanco.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Cache HTTP request sessions between API calls
Docs: Omit
Avoid creating a new session for each ConanRequester instance, this helps a lot with performance, as it avoids the overhead duplicate handshakes
I get an additional 40% speedup on top of #17449