-
Notifications
You must be signed in to change notification settings - Fork 171
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix parsing parent element container from props (#6681)
**Problem:** The `parentContainerGridPropertiesFromProps` in the special size measurements is incorrectly calcluated off of the computed style of the parent. This results, among other issues, into the template being serialized to its computed values whenever `gridMoveStrategiesExtraCommands` is applied inside strategies (e.g. right after moving a grid item). **Fix:** Try to use the parent element style directly when parsing. | Before | After | |--------|------------| | https://github.com/user-attachments/assets/3a3a62b4-c030-422d-bd69-d80e52a76ef5 | https://github.com/user-attachments/assets/ffbc2c3e-e7b3-4812-b9b4-71d096030b94 | **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode Fixes #6680
- Loading branch information
Showing
2 changed files
with
113 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters