Skip to content

Commit

Permalink
fix(grid): move controls when changing content placement (#6350)
Browse files Browse the repository at this point in the history
**Problem:**
Today the grid controls placeholder don't move when changing `content`
placement

![10-45-psczv-wnkpg](https://github.com/user-attachments/assets/ea5d2623-0705-4337-8aa2-6d0139addec8)
 

**Fix:**
Copy `justifyContent` and `alignContent` props to the grid placeholder
as well.

<video
src="https://github.com/user-attachments/assets/0e8dfd6e-f6ca-4b46-bd83-89b2472d03a8"></video>

**Note:**
We should discuss how we can avoid these kinds of issues in the future -
where there might be a future grid style prop that will not be copied to
the grid control

**Manual Tests:**
I hereby swear that:

- [X] I opened a hydrogen project and it loaded
- [X] I could navigate to various routes in Preview mode
  • Loading branch information
liady authored Sep 11, 2024
1 parent d3a7bb8 commit b142af6
Show file tree
Hide file tree
Showing 7 changed files with 279 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ Object {
"label": null,
"nonRoundedGlobalFrame": null,
"specialSizeMeasurements": Object {
"alignContent": null,
"alignItems": null,
"borderRadius": null,
"clientHeight": 0,
Expand Down Expand Up @@ -304,6 +305,7 @@ Object {
"label": null,
"nonRoundedGlobalFrame": null,
"specialSizeMeasurements": Object {
"alignContent": null,
"alignItems": null,
"borderRadius": null,
"clientHeight": 0,
Expand Down
Loading

0 comments on commit b142af6

Please sign in to comment.