Skip to content

Commit

Permalink
Grid advanced modal: visible allowed values outside of shown options …
Browse files Browse the repository at this point in the history
…for justify/align dropdown (#6585)

**Problem:**

Acceptable values for the dropdowns in the grid advanced modal for
justify/align content should still be visible in the dropdown when set,
even if we don't show them in the full dropdown itself by default.

**Fix:**

1. Add the missing acceptable values to the type enums in `flex.ts`
2. Restrict which values we show in the dropdown to the ones we had so
far (we can tweak this as we go)
3. Add the ability to show an extra dropdown row at the top of the list
if its value is allowed for that dropdown and it's not found in the
available options



https://github.com/user-attachments/assets/9c22d25e-6ac1-4569-945d-e85d22e5fdb2



Fixes #6584
  • Loading branch information
ruggi authored and liady committed Dec 13, 2024
1 parent d4d0d72 commit e1335e6
Show file tree
Hide file tree
Showing 4 changed files with 91 additions and 5 deletions.
9 changes: 9 additions & 0 deletions editor/src/components/inspector/common/css-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4620,6 +4620,11 @@ const flexAlignmentsParser: Parser<FlexAlignment> = isOneOfTheseParser([
FlexAlignment.Center,
FlexAlignment.FlexEnd,
FlexAlignment.Stretch,
FlexAlignment.Baseline,
FlexAlignment.FirstBaseline,
FlexAlignment.LastBaseline,
FlexAlignment.SafeCenter,
FlexAlignment.UnsafeCenter,
])

const flexJustifyContentParser: Parser<FlexJustifyContent> = isOneOfTheseParser([
Expand All @@ -4629,6 +4634,10 @@ const flexJustifyContentParser: Parser<FlexJustifyContent> = isOneOfTheseParser(
FlexJustifyContent.SpaceAround,
FlexJustifyContent.SpaceBetween,
FlexJustifyContent.SpaceEvenly,
FlexJustifyContent.Stretch,
FlexJustifyContent.Normal,
FlexJustifyContent.SafeCenter,
FlexJustifyContent.UnsafeCenter,
])

export type CSSPosition = '-webkit-sticky' | 'absolute' | 'fixed' | 'relative' | 'static' | 'sticky'
Expand Down
22 changes: 19 additions & 3 deletions editor/src/components/inspector/controls/advanced-grid-modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
separatorRadixSelectOption,
} from '../../../uuiui/radix-components'
import { optionalMap } from '../../../core/shared/optional-utils'
import { FlexAlignment } from 'utopia-api/core'
import { AllFlexAlignments, AllFlexJustifyContents, FlexAlignment } from 'utopia-api/core'
import { FlexJustifyContent } from 'utopia-api/core'
import { GridAutoColsOrRowsControlInner } from '../grid-auto-cols-or-rows-control'
import { Substores, useEditorState, useRefEditorState } from '../../editor/store/store-hook'
Expand Down Expand Up @@ -82,13 +82,27 @@ export const AdvancedGridModal = React.memo((props: AdvancedGridModalProps) => {
const justifyOptions = [
unsetSelectOption,
separatorRadixSelectOption(),
...Object.values(FlexJustifyContent).map(selectOption),
...[
FlexJustifyContent.FlexStart,
FlexJustifyContent.Center,
FlexJustifyContent.FlexEnd,
FlexJustifyContent.SpaceAround,
FlexJustifyContent.SpaceBetween,
FlexJustifyContent.SpaceEvenly,
FlexJustifyContent.Stretch,
].map(selectOption),
]

const alignOptions = [
unsetSelectOption,
separatorRadixSelectOption(),
...Object.values(FlexAlignment).map(selectOption),
...[
FlexAlignment.Auto,
FlexAlignment.FlexStart,
FlexAlignment.Center,
FlexAlignment.FlexEnd,
FlexAlignment.Stretch,
].map(selectOption),
]

const onSubmitJustifyContent = React.useCallback(
Expand Down Expand Up @@ -200,6 +214,7 @@ export const AdvancedGridModal = React.memo((props: AdvancedGridModalProps) => {
zIndex: 1,
}}
onOpenChange={toggleJustifyContentDropdown}
allowedValues={AllFlexJustifyContents}
/>
</UIGridRow>
<UIGridRow
Expand All @@ -218,6 +233,7 @@ export const AdvancedGridModal = React.memo((props: AdvancedGridModalProps) => {
zIndex: 1,
}}
onOpenChange={toggleAlignContentDropdown}
allowedValues={AllFlexAlignments}
/>
</UIGridRow>
<UIGridRow padded variant='<-------------1fr------------->'>
Expand Down
49 changes: 47 additions & 2 deletions editor/src/uuiui/radix-components.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { when } from '../utils/react-conditionals'
import { Icn, type IcnProps } from './icn'
import { forceNotNull } from '../core/shared/optional-utils'
import { usePropControlledStateV2 } from '../components/inspector/common/inspector-utils'
import { assertNever } from '../core/shared/utils'

// Keep this in sync with the radix-components-portal div in index.html.
export const RadixComponentsPortalId = 'radix-components-portal'
Expand Down Expand Up @@ -256,6 +257,29 @@ export function separatorRadixSelectOption(): Separator {

export type RadixSelectOption = RegularRadixSelectOption | Separator

function equalRadixSelectOptions(
a: RadixSelectOption | null,
b: RadixSelectOption | null,
): boolean {
if (a == null && b == null) {
return true
}
if (a == null || b == null) {
return false
}
switch (a.type) {
case 'REGULAR':
if (b.type !== 'REGULAR') {
return false
}
return a.value === b.value && a.label === b.label
case 'SEPARATOR':
return b.type === 'SEPARATOR'
default:
assertNever(a)
}
}

function optionLabelToString(
option: RegularRadixSelectOption | null,
isOpen: boolean,
Expand All @@ -280,6 +304,7 @@ export const RadixSelect = React.memo(
onValueChange?: (value: string) => void
contentClassName?: string
onOpenChange?: (open: boolean) => void
allowedValues?: string[]
}) => {
const stopPropagation = React.useCallback((e: React.KeyboardEvent) => {
e.stopPropagation()
Expand All @@ -296,7 +321,27 @@ export const RadixSelect = React.memo(
[propsOnOpenChange],
)

const valueLabel = optionLabelToString(props.value ?? null, isOpen, props.value?.value ?? null)
const valueLabel = React.useMemo(() => {
return optionLabelToString(props.value ?? null, isOpen, props.value?.value ?? null)
}, [props.value, isOpen])

const options = React.useMemo(() => {
let fullOptions = [...props.options]

if (
// the value is not null
props.value != null &&
// the value is allowed for this dropdown
props.allowedValues?.some((allowed) => allowed === props.value?.value) &&
// the options don't contain the value already
!fullOptions.some((opt) => equalRadixSelectOptions(opt, props.value))
) {
// add the given option + separator at the top of the options
fullOptions.unshift(...[props.value, separatorDropdownMenuItem('unknown-dropdown-value')])
}

return fullOptions
}, [props.options, props.value, props.allowedValues])

return (
<Select.Root
Expand Down Expand Up @@ -355,7 +400,7 @@ export const RadixSelect = React.memo(
gap: 2,
}}
>
{props.options.map((option, index) => {
{options.map((option, index) => {
if (option.type === 'SEPARATOR') {
return (
<Select.Separator
Expand Down
16 changes: 16 additions & 0 deletions utopia-api/src/layout/flex.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,11 @@ export enum FlexAlignment {
Center = 'center',
FlexEnd = 'flex-end',
Stretch = 'stretch',
Baseline = 'baseline',
FirstBaseline = 'first baseline',
LastBaseline = 'last baseline',
SafeCenter = 'safe center',
UnsafeCenter = 'unsafe center',
}

export const AllFlexAlignments: Array<FlexAlignment> = [
Expand All @@ -206,6 +211,11 @@ export const AllFlexAlignments: Array<FlexAlignment> = [
FlexAlignment.Center,
FlexAlignment.FlexEnd,
FlexAlignment.Stretch,
FlexAlignment.Baseline,
FlexAlignment.FirstBaseline,
FlexAlignment.LastBaseline,
FlexAlignment.SafeCenter,
FlexAlignment.UnsafeCenter,
]

export enum FlexJustifyContent {
Expand All @@ -216,6 +226,9 @@ export enum FlexJustifyContent {
SpaceBetween = 'space-between',
SpaceEvenly = 'space-evenly',
Stretch = 'stretch',
Normal = 'normal',
SafeCenter = 'safe center',
UnsafeCenter = 'unsafe center',
}

export const AllFlexJustifyContents: Array<FlexJustifyContent> = [
Expand All @@ -226,6 +239,9 @@ export const AllFlexJustifyContents: Array<FlexJustifyContent> = [
FlexJustifyContent.SpaceBetween,
FlexJustifyContent.SpaceEvenly,
FlexJustifyContent.Stretch,
FlexJustifyContent.Normal,
FlexJustifyContent.SafeCenter,
FlexJustifyContent.UnsafeCenter,
]

export enum FlexDirection {
Expand Down

0 comments on commit e1335e6

Please sign in to comment.