Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move grid placement section below layout, use self alignment icons for grid/flex children #6501

Closed
ruggi opened this issue Oct 9, 2024 · 0 comments · Fixed by #6502
Closed

Move grid placement section below layout, use self alignment icons for grid/flex children #6501

ruggi opened this issue Oct 9, 2024 · 0 comments · Fixed by #6502
Assignees
@ruggi

Comments

@ruggi
Copy link
Contributor

ruggi commented Oct 9, 2024

No description provided.

@ruggi ruggi self-assigned this Oct 9, 2024
@ruggi ruggi mentioned this issue Oct 9, 2024
Merged
@ruggi ruggi closed this as completed in 29c7829 Oct 9, 2024
liady pushed a commit that referenced this issue Dec 13, 2024
@ruggi @liady
Move grid placement section below layout, use self alignment icons fo…
8017f95 
…r grid/flex children (#6502)

**Problem:**

1. The grid placement subsection should be just below the layout
section, since they are all related to the positioning of the selected
element
2. Grid and Flex children should use the `[align|justify]Self` icons for
the alignment buttons instead of the non-self ones.

**Fix:**

Do that.

| Before | After |
|---------|--------------|
| <img width="276" alt="Screenshot 2024-10-09 at 11 48 24"
src="https://github.com/user-attachments/assets/384dd748-17c6-4553-9d38-11b6c9dd1c8f">
|<img width="276" alt="Screenshot 2024-10-09 at 11 48 06"
src="https://github.com/user-attachments/assets/31a3beb2-5201-4980-b9aa-1e19382d53eb">
|


Fixes #6501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruggi ruggi

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ruggi