Hide area name in grid expression inputs #6452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbalint
approved these changes
Oct 2, 2024
#14522 Bundle Size — 57.79MiB (~+0.01%).8854dfa(current) vs 916e8b9 master#14521(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14522 |
Baseline #14521 |
|
|---|---|---|
 Initial JS |
40.74MiB(~+0.01%) |
40.74MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.03% |
18.02% |
| Chunks |
23 |
23 |
| Assets |
25 |
25 |
| Modules |
4106 |
4106 |
| Duplicate Modules |
214 |
214 |
| Duplicate Code |
27.47% |
27.47% |
| Packages |
475 |
475 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14522 |
Baseline #14521 |
|
|---|---|---|
| JS |
57.78MiB (~+0.01%) |
57.78MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch fix/hide-area-name-grid-input Project dashboard
Generated by RelativeCI Documentation Report issue
| @@ -250,7 +250,7 @@ const TemplateDimensionControl = React.memo( | |||
| 'always', | |||
| grid.elementPath, | |||
| PP.create('style', axis === 'column' ? 'gridTemplateColumns' : 'gridTemplateRows'), | |||
| printArrayGridDimensions(newDimensions), | |||
| printArrayGridDimensions(newDimensions, 'show-area-name'), | |||
There was a problem hiding this comment.
"show" feels very wrong here, since this function is about generating the template string which goes into the actual code update. I wonder if we should split this into two helper functions, stringifyArrayGridDimensions and something else for getting the visual printed version
bkrmendy
approved these changes
Oct 2, 2024
balazsbajorics
approved these changes
Oct 2, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** Area names should not be shown in the string inputs used for grid template values. **Fix:** Set the flag to hide area names in `GridExpressionInput`. For the future, I also made that flag mandatory and a string union instead of a boolean flag, as `'show-area-name' | 'hide-area-name'`. Fixes #6451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Area names should not be shown in the string inputs used for grid template values.
Fix:
Set the flag to hide area names in
GridExpressionInput. For the future, I also made that flag mandatory and a string union instead of a boolean flag, as'show-area-name' | 'hide-area-name'.Fixes #6451