Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import): correctly identify a default exported component #6453

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Oct 2, 2024

Problem:
Today we don't recognize when a default export is declared separately.

function App(){...}
export default App

this is not treated as a component when it's imported:

Monosnap.screencast.2024-10-02.14-48-14.mp4

Fix:
Use isExportDefault instead of a specific check for a function or a class

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

Fixes #6439

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Try me

Copy link

relativeci bot commented Oct 2, 2024

#14615 Bundle Size — 57.76MiB (~-0.01%).

9467373(current) vs 916e8b9 master#14614(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#14615
     Baseline
#14614
Improvement  Initial JS 40.76MiB(~-0.01%) 40.76MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.49% 38.03%
No change  Chunks 21 21
No change  Assets 23 23
No change  Modules 4112 4112
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.4% 27.4%
No change  Packages 475 475
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#14615
     Baseline
#14614
Improvement  JS 57.75MiB (~-0.01%) 57.75MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/default-export-compProject dashboard


Generated by RelativeCIDocumentationReport issue

@liady liady changed the title fix(import): identify correctly when a default exported component is defined seperately fix(import): correctly identif a default exported component Oct 4, 2024
@liady liady changed the title fix(import): correctly identif a default exported component fix(import): correctly identify a default exported component Oct 4, 2024
@liady liady merged commit 52508eb into master Oct 7, 2024
14 checks passed
@liady liady deleted the fix/default-export-comp branch October 7, 2024 11:05
liady added a commit that referenced this pull request Dec 13, 2024
**Problem:**
Today we don't recognize when a default export is declared separately.
```ts
function App(){...}
export default App
```
this is not treated as a component when it's imported:

<video
src="https://github.com/user-attachments/assets/a52ce448-c324-44e9-bae1-9c64c3af21e5"></video>

**Fix:**
Use `isExportDefault` instead of a specific check for a function or a
class

**Manual Tests:**
I hereby swear that:

- [x] I opened a hydrogen project and it loaded
- [x] I could navigate to various routes in Play mode

Fixes #6439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import { default as App } prevents selecting elements inside App
3 participants