always call exitPointerLock #6458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liady
approved these changes
Oct 2, 2024
#14533 Bundle Size — 57.79MiB (~-0.01%).a1d2531(current) vs 916e8b9 master#14532(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14533 |
Baseline #14532 |
|
|---|---|---|
 Initial JS |
40.74MiB(~-0.01%) |
40.74MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.03% |
18.26% |
| Chunks |
23 |
23 |
| Assets |
25 |
25 |
| Modules |
4106 |
4106 |
| Duplicate Modules |
214 |
214 |
| Duplicate Code |
27.47% |
27.47% |
| Packages |
475 |
475 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 2 improvements
| Current #14533 |
Baseline #14532 |
|
|---|---|---|
| JS |
57.78MiB (~-0.01%) |
57.78MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch fix/pointer-lock Project dashboard
Generated by RelativeCI Documentation Report issue
seanparsons
approved these changes
Oct 2, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
**Problem:** If a scrubbing using the new pointer lock based scrubber control was quick enough, we would often not release the pointer on mouse up – instead leaving you with a hidden cursor until you press Esc. **Fix:** Turns out, `document.pointerLockElement` is still null for a few moments after getting pointer lock, and our code calling `document.exitPointerLock` checks if the pointer lock element is the same as the current control's target. By simply removing the check, we call exitPointerLock() all of the time, making it not brittle anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If a scrubbing using the new pointer lock based scrubber control was quick enough, we would often not release the pointer on mouse up – instead leaving you with a hidden cursor until you press Esc.
Fix:
Turns out,
document.pointerLockElementis still null for a few moments after getting pointer lock, and our code callingdocument.exitPointerLockchecks if the pointer lock element is the same as the current control's target.By simply removing the check, we call exitPointerLock() all of the time, making it not brittle anymore.