Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the Tailwind config in the editor state #6497

Closed
wants to merge 3 commits into from

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Oct 8, 2024

split out from #6492

Problem

The Tailwind config is only accessible inside useTailwindCompilation, which means that the upcoming element style plugins won't be able to access it

Fix

Store the Tailwind config in the editor state, the same way that we store the property control descriptors. This way, the tailwind config will be accessible from hooks, actions, the strategy dispatch etc.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Try me

Copy link

relativeci bot commented Oct 8, 2024

#14648 Bundle Size — 57.74MiB (~+0.01%).

f553ca5(current) vs 916e8b9 master#14647(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14648
     Baseline
#14647
Regression  Initial JS 40.75MiB(~+0.01%) 40.74MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.26% 17.95%
No change  Chunks 21 21
No change  Assets 23 23
No change  Modules 4113 4113
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.41% 27.41%
No change  Packages 475 475
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14648
     Baseline
#14647
Regression  JS 57.74MiB (~+0.01%) 57.73MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch feature/tailwind-in-editor-stateProject dashboard


Generated by RelativeCIDocumentationReport issue

@bkrmendy bkrmendy changed the title wip Store the Tailwind config in the editor state Oct 8, 2024
@bkrmendy bkrmendy marked this pull request as ready for review October 8, 2024 16:05
@bkrmendy
Copy link
Contributor Author

bkrmendy commented Oct 9, 2024

closed in favor of #6500

@bkrmendy bkrmendy closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant