Grid Template Field Dropdowns #6498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Integrated some similar logic into `GridExpressionInput` that is in `NumberOrKeywordControl`. - Resurrected `gridDimensionDropdownKeywords` from the previous code so that it can be passed to `GridExpressionInput`.
seanparsons
requested review from
gbalint,
Rheeseyb,
ruggi,
balazsbajorics,
liady and
bkrmendy
#14665 Bundle Size — 57.74MiB (~+0.01%).94fb012(current) vs 916e8b9 master#14662(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #14665 |
Baseline #14662 |
|
|---|---|---|
 Initial JS |
40.74MiB(~+0.01%) |
40.74MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
17.96% |
0% |
| Chunks |
21 |
21 |
| Assets |
23 |
23 |
| Modules |
4113 |
4113 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.41% |
27.41% |
| Packages |
475 |
475 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #14665 |
Baseline #14662 |
|
|---|---|---|
| JS |
57.73MiB (~+0.01%) |
57.73MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch feature/grid-field-dropdowns Project dashboard
Generated by RelativeCI Documentation Report issue
gbalint
approved these changes
Oct 8, 2024
ruggi
approved these changes
Oct 9, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
- Integrated some similar logic into `GridExpressionInput` that is in `NumberOrKeywordControl`. - Resurrected `gridDimensionDropdownKeywords` from the previous code so that it can be passed to `GridExpressionInput`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Previously the grid template column fields in the inspector supported a dropdown with some stock keywords in it. It would be nice if those returned.
Fix:
Some logic akin to that present in
NumberOrKeywordControlhas been implemented intoGridExpressionInput.Commit Details:
GridExpressionInputthat is inNumberOrKeywordControl.gridDimensionDropdownKeywordsfrom the previous code so that it can be passed toGridExpressionInput.Manual Tests:
I hereby swear that: